Hi, it doesn't seem like your test case tests the implementation

Thank you @mspruc for the feedback! You’re right
the current test only checks the SQL string generation and doesn’t actually verify execution. Right now it covers things like SQL generation with AND clauses and correct table and column names. We could improve it by running the generated SQL and checking the results, such as making sure the correct number of rows is returned, joins match properly (for example, order_id=1 and customer_id=100), and data from both tables is combined correctly. Would you like me to add a full integration test to validate execution and results?

Hi @mspruc,

Can you review this, if any improvement or changes required please mention.

Hi,
Your test still doesn't test the SQL-API implementation.

Hi @mspruc,

Thanks for your patience! I’ve added sqlApiMultiConditionJoinGeneratesJdbcSql in SqlToWayangRelTest.java to cover SQL API parsing, multi-condition JOIN, table names, and field names.

As a new contributor, I really appreciate your guidance - please let me know if any changes are needed.

Thanks again!

Hi @mspruc,

Can you review this, if any improvement or changes required please mention.

Hi, why have you changed several List.of() to Arrays.asList()?

Hi @mspruc ,

Thanks for pointing this out.

I changed List.of() to Arrays.asList() while working on the SQL implementation because I wanted to align with how lists are being passed to Calcite APIs in other parts of the codebase (e.g., places where Arrays.asList() is used when interacting with LogicalTableScan and SQL generation utilities).

My intention was to avoid any potential incompatibility with Calcite’s internal handling of lists (especially since Calcite relies heavily on Guava’s ImmutableList internally), and to stay consistent with the existing usage patterns in the SQL-related modules.

That said, there is no strong technical constraint that strictly requires Arrays.asList() here. If List.of() is preferred (e.g., for immutability or modern Java style), I’m happy to revert those changes.

Thanks